Is it possible to update dictionaries?

[madsmunck8]

Godot Version

4.3

Question

So, essentially I am trying to update this dictionary every time I press mouse click. Currently I have this dictionary in my script:

var move = {
	1:{
		"Vector": Vector2(TilePosition)
	},
	2:{
		"Vector": Vector2((TilePosition.x + 1), TilePosition.y)
	},
	3:{
		"Vector": Vector2((TilePosition.x + 2), TilePosition.y)
	},
	4:{
		"Vector": Vector2((TilePosition.x + 3), TilePosition.y)
	},
	5:{
		"Vector": Vector2((TilePosition.x + 1), (TilePosition.y + 1))
	},
	6:{
		"Vector": Vector2((TilePosition.x + 1), (TilePosition.y + 2))
	},
	7:{
		"Vector": Vector2((TilePosition.x + 2), (TilePosition.y + 1))
	},
	8:{
		"Vector": Vector2((TilePosition.x + 2), (TilePosition.y + 2))
	},
	9:{
		"Vector": Vector2((TilePosition.x - 1), (TilePosition.y))
	},
	10:{
		"Vector": Vector2((TilePosition.x - 2), (TilePosition.y))
	},
	11:{
		"Vector": Vector2((TilePosition.x - 3), (TilePosition.y))
	},
	12:{
		"Vector": Vector2((TilePosition.x - 1), (TilePosition.y - 1))
	},
	13:{
		"Vector": Vector2((TilePosition.x - 1), (TilePosition.y - 2))
	},
	14:{
		"Vector": Vector2((TilePosition.x - 2), (TilePosition.y - 1))
	},
	15:{
		"Vector": Vector2((TilePosition.x - 2), (TilePosition.y - 2))
	},
	16:{
		"Vector": Vector2((TilePosition.x - 2), (TilePosition.y + 1))
	},
	17:{
		"Vector": Vector2((TilePosition.x - 2), (TilePosition.y + 2))
	},
	18:{
		"Vector": Vector2((TilePosition.x - 1), (TilePosition.y + 1))
	},
	19:{
		"Vector": Vector2((TilePosition.x + 1), (TilePosition.y - 1))
	},
	20:{
		"Vector": Vector2((TilePosition.x - 1), (TilePosition.y + 2))
	},
	21:{
		"Vector": Vector2((TilePosition.x), (TilePosition.y - 1))
	},
	22:{
		"Vector": Vector2((TilePosition.x), (TilePosition.y - 2))
	},
	23:{
		"Vector": Vector2((TilePosition.x), (TilePosition.y - 3))
	},
	24:{
		"Vector": Vector2((TilePosition.x), (TilePosition.y + 1))
	},
	25:{
		"Vector": Vector2((TilePosition.x), (TilePosition.y + 2))
	},
	26:{
		"Vector": Vector2((TilePosition.x), ((TilePosition).y + 3))
	}
}

(I am sure there are wayyyy better ways of doing this, but I couldn’t think of any… I am quite new to godot)

then I have a code that uses this dictionary:

func _input(event):
	if event.is_action_pressed("Move") == false:
		return
	if tile_map_layer.local_to_map(get_global_mouse_position()) == tile_map_layer.local_to_map(global_position):
		TilePosition = tile_map_layer.local_to_map(global_position)
		print(TilePosition)
		for i in move:
			print(move[i]["Vector"])
			tile_map_layer.set_cell((move[i]["Vector"]), 1, Yellowtile)

I’ve tried adding “move.update()” or similar, but I get errors. I’ve printed the outputs, and print(TilePosition) gives f.ex (4, 13), while print(move[i][“Vector”]) gives f.ex (3,0) - (-3, 0) and same with y… so the default values I’ve put without TilePosition… So yes, It would be great if there was some way to update the dictionary every time I mouseclick or something

[pham150603]

I don’t fully understand what you trying to do but you can detect mouse click with this

func _input(event:InputEvent) -> void:
	if event is InputEventMouseButton:
		if event.button_index == MOUSE_BUTTON_LEFT:
			update the dictionary

[madsmunck8]

I already detect mouseclick using event.is_action_pressed… I just need some way for the dictionary to update based on the variable key. So when the TilePosition variable becomes f.ex (9, 13), the Vector2((Tileposition.x +1), TilePosition.y) should become (10, 13), not (1, 0) which is what it prints at the current moment. But I don’t know how variables work in dictionaries. but it would atleast be nice if it was possible for the dictionary to update every time my ‘event.is_action_pressed’ gets triggered. move.update() just does not work, and I don’t find anything else that works

[TokyoFunkScene]

I’m unsure I fully understand your problem, but it seems like you’re making a bit of code where you can select a certain cell, and the code will color all tiles surrounding that space (and are no more than three spaces away) yellow. Is that correct?

You could probably simplify your code a whole lot.

func get_neighbours(tile_position : Vector2i)->Array[Vector2i]:
	var neighbours : Array[Vector2i] = []
	neighbours.append(Vector2i(tile_position.x + 1, tile_position.y + 1))
	neighbours.append(Vector2i(tile_position.x + 2, tile_position.y + 2))
	# et cetera
	return neighbours

This method accepts a single Vector2i, which should be the tile you selected. It returns a list of all neighbours. You only need to iterate over the returned list like so:

var some_position : Vector2i = Vector2i(100, 100) # Replace with your selected position.
var neighbours_array : Array[Vector2i] = get_neighbours(some_position)
for neighbour in neighbours_array:
	tile_map_layer.set_cell(neighbour, 1, Yellowtile)

Please note I haven’t actually tested this code.

[madsmunck8]

I tried your array, but it gave the error code “Error at (94,16): Invalid index type “Vector2i” for a base of type “Array[Vector2i]””

[pham150603]

@TokyoFunkScene

a bit of code where you can select a certain cell, and the code will color all tiles surrounding that space

I see it now
can you try this

func get_neighbours(TILE: Vector2, X: int) -> Array:
	var surrounding_tiles = []
	for a in range(-X, X):
		for b in range(-X, X):
			var current_tile = Vector2(a, b)
			if not surrounding_tiles.has(current_tile) and current_tile != TILE:
				surrounding_tiles.append(current_tile)
	return surrounding_tiles

func _input(event):
	if event.is_action_pressed("Move") == false:
		return
	if tile_map_layer.local_to_map(get_global_mouse_position()) == tile_map_layer.local_to_map(global_position):
		TilePosition = tile_map_layer.local_to_map(global_position)
		move = get_neighbours(TilePosition,2)
		for i in move:
			tile_map_layer.set_cell((move[i]["Vector"]), 1, Yellowtile)

[madsmunck8]

`and yes, you are correct, I am trying to color all tiles surrounding my main character

[madsmunck8]

uuuuh. I got the error “Invalid access to property of key ‘(-3, -3)’ on a base object of type ‘Array’”, I tried to #
for i in move: tile_map_layer.set_cell((move[i]["Vector"]), 1, Yellowtile)
and instead type print(get_neighbours(TilePosition, 2)) to check the values, but it still gives values between -3 and +3 instead of the actual position of TilePosition ±3

[pham150603]

my bad

func get_neighbours(TILE: Vector2, X: int) -> Array:
	var surrounding_tiles = []
	for a in range(-X, X):
		for b in range(-X, X):
			var current_tile = Vector2(a, b)
			if not surrounding_tiles.has(current_tile) and current_tile != TILE:
				surrounding_tiles.append(current_tile)
	return surrounding_tiles

func _input(event):
	if event.is_action_pressed("Move") == false:
		return
	if tile_map_layer.local_to_map(get_global_mouse_position()) == tile_map_layer.local_to_map(global_position):
		TilePosition = tile_map_layer.local_to_map(global_position)
		move = get_neighbours(TilePosition,2)
		for i in move:
			tile_map_layer.set_cell((move[i]), 1, Yellowtile)

[madsmunck8]

hmmm, it still gives the same error message

[pham150603]

i forgot about for loop for dictionary

func get_neighbours(TILE: Vector2, X: int) -> Array:
	var surrounding_tiles = []
	for a in range(-X, X + 1):
		for b in range(-X, X + 1):
			var current_tile = TILE + Vector2(a, b)
			if current_tile != TILE:  # Ensure center tile is not included
				surrounding_tiles.append(current_tile)
	return surrounding_tiles

func _input(event):
	if event.is_action_pressed("Move") == false:
		return
	
	if tile_map_layer.local_to_map(get_global_mouse_position()) == tile_map_layer.local_to_map(global_position):
		TilePosition = tile_map_layer.local_to_map(global_position)
		move = get_neighbours(TilePosition, 2)
		
		for tile in move:
			tile_map_layer.set_cell(tile, 1, Yellowtile)

[madsmunck8]

thankyou, that works!

[pham150603]

you can also change the radius dynamically with the function

[madsmunck8]

Yea, that is true. Right now it is also square. There is probably also a way to make it more circle-like?

[pham150603]

try this

func get_circle_neighbours(TILE: Vector2, radius: int) -> Array:
	var surrounding_tiles = []
	for a in range(-radius, radius + 1):
		for b in range(-radius, radius + 1):
			var current_tile = TILE + Vector2(a, b)
			if current_tile != TILE and current_tile.distance_to(TILE) <= radius:
				surrounding_tiles.append(current_tile)
	return surrounding_tiles

[madsmunck8]

it sort of works. it creates a circle, however I’m not able to put in values to make it bigger or smaller… other than that it creates a nice cirlce that surrounds the character

[pham150603]

what do you mean by

@madsmunck8

not able to put in values to make it bigger or smaller

[madsmunck8]

well, in the first get_neighbourgs function, whatever I put in the “for a in range(-x, x + 1):” would change the size of the square. but in the get_circle_neighbors nothing changes when I change numbers, the circle only covers the first tiles surrounding the character

[pham150603]

that not exactly how you use the function, here let me make it clear for you

func get_circle_neighbours(TILE: Vector2, radius: int) -> Array:
	var surrounding_tiles = []
	for a in range(-radius, radius + 1):
		for b in range(-radius, radius + 1):
			var current_tile = TILE + Vector2(a, b)
			if current_tile != TILE and current_tile.distance_to(TILE) <= radius:
				surrounding_tiles.append(current_tile)
	return surrounding_tiles

func get_square_neighbours(TILE: Vector2, X: int) -> Array:
	var surrounding_tiles = []
	for a in range(-X, X + 1):
		for b in range(-X, X + 1):
			var current_tile = TILE + Vector2(a, b)
			if current_tile != TILE:  # Ensure center tile is not included
				surrounding_tiles.append(current_tile)
	return surrounding_tiles

func _input(event):
	if event.is_action_pressed("Move") == false:
		return
	
	if tile_map_layer.local_to_map(get_global_mouse_position()) == tile_map_layer.local_to_map(global_position):
		TilePosition = tile_map_layer.local_to_map(global_position)
		move = get_square_neighbours(TilePosition, 2) #this is where you modify the shape and radius, 2 is the radius of the circle or square
		
		for tile in move:
			tile_map_layer.set_cell(tile, 1, Yellowtile)

change it to
move = get_square_neighbours(TilePosition, 3) #if you want a 7x7 square
move = get_circle_neighbours(TilePosition, 4) #if you want a 4 radius circle

[madsmunck8]

Oh, I see…
In retrospect that seems rather logical.
Thank you, that works well