My player jumps endlessly

Help Physics
, ,
1

Hello, I have a problem with my player : when I press the jump input one time, he jumps endlessly. I tried to document myself on the problem, I watched tutorials and I still can’t make it work correctly. Here is the code :

extends NodeState

@export var character_body_2d : CharacterBody2D
@export var animated_sprite_2d : AnimatedSprite2D

@export_category("Jump State")
@export var jump_height :  float = -250
@export var jump_horizontal_speed : int = 500
@export var max_jump_horizontal_speed : int = 300
@export var max_jump_count : int = 1
@export var jump_gravity : int = 1000

var current_jump_count : int
var coyote_jump : bool

func on_process(delta : float):
    pass


func on_physics_process(delta : float):

    character_body_2d.velocity.y += jump_gravity * delta

    if character_body_2d.is_on_floor():
        current_jump_count = 0
        character_body_2d.velocity.y = jump_height
        coyote_jump = false
        current_jump_count += 1

    if coyote_jump:
        character_body_2d.velocity.y = jump_height
        coyote_jump = false
        current_jump_count += 1

multiple jumps
    if !character_body_2d.is_on_floor() and GameInputEvents.jump_input() and current_jump_count != max_jump_count:
        character_body_2d.velocity.y = jump_height
        current_jump_count += 1

    var direction : float = GameInputEvents.movement_input()

    if !character_body_2d.is_on_floor():
        character_body_2d.velocity.x += direction * jump_horizontal_speed
        character_body_2d.velocity.x = clamp(character_body_2d.velocity.x, -max_jump_horizontal_speed, max_jump_horizontal_speed)

    character_body_2d.move_and_slide()

transitioning states
idle state
    if character_body_2d.is_on_floor():
        transition.emit("Idle")

func enter():
    animated_sprite_2d.play("jump")
    coyote_jump = true


func exit():
    animated_sprite_2d.stop()
    coyote_jump = false
2

Could you describe the problem in a little more detail
Does the player keep going up? Or does the player constantly reenter the state after jumping, falling and hitting the ground? If the player keeps reentering the state, the problem is probably in another state.

How do you call “on_physics_process(delta)”? If it’s called just like _physics_process(delta), then the function will trigger every frame, whether or not the player is in the state (this might be what’s causing the issue)

3

Hello, sorry, I forgot to say that I solved this problem on my own by just adding if !character_body_2d.is_on_floor() and GameInputEvents.jump_input() and current_jump_count != max_jump_count:
a second time. Still thank you for your help.

1 Like