Waves keep spawning

Help Programming
,
1

4.3

My waves keep spawning without needing to be killed i want the next wave to start when he killed all enemies

extends Node2D

@onready var SceneTransitionAnimation = $SceneTransitionAnimation/AnimationPlayer
@onready var player_camera = $player/Camera2D

var current_wave: int
@export var bat_scene : PackedScene
@export var frog_scene : PackedScene

var starting_nodes: int
var current_nodes: int
var wave_spawn_ended

# Called when the node enters the scene tree for the first time.
func _ready():
	SceneTransitionAnimation.get_parent().get_node("ColorRect").color.a = 255
	SceneTransitionAnimation.play("fade_out")
	player_camera.enabled = true
	Global.playerWeaponEquip = true
	current_wave = 0
	Global.current_wave = current_wave
	starting_nodes = get_child_count()
	current_nodes = get_child_count()
	position_to_next_wave()
	
	
func position_to_next_wave():
	if current_nodes == starting_nodes:
		if current_wave != 0:
			Global.moving_to_next_wave = true
		wave_spawn_ended = false
		SceneTransitionAnimation.play("between_wave")
		current_wave += 1
		Global.current_wave = current_wave
		await get_tree().create_timer(0.5).timeout
		prepare_spawn("bats", 4.0, 4.0) # type, multiplier, spawn
		prepare_spawn("frogs",1.5, 2.0)
		print(current_wave)

func prepare_spawn(type, multiplier, mob_spawns):
	var mob_amount = float(current_wave) * multiplier
	var mob_wait_time: float = 2.0
	print("mob_amount: ", mob_amount)
	var mob_spawn_rounds = mob_amount/mob_spawns
	spawn_type(type, mob_spawn_rounds, mob_wait_time)
	
func spawn_type(type, mob_spawn_rounds, mob_wait_time): 
	if type == "bats":
		var bat_spawn1 = $BatSpawnPoint1
		var bat_spawn2 = $BatSpawnPoint2
		var bat_spawn3 = $BatSpawnPoint3
		var bat_spawn4 = $BatSpawnPoint4
		if mob_spawn_rounds >= 1:
			for i in mob_spawn_rounds:
				print("yes")
				var bat1 = bat_scene.instantiate()
				bat1.global_position = bat_spawn1.global_position 
				var bat2 = bat_scene.instantiate()
				bat2.global_position = bat_spawn2.global_position 
				var bat3 = bat_scene.instantiate()
				bat3.global_position = bat_spawn3.global_position 
				var bat4 = bat_scene.instantiate()
				bat4.global_position = bat_spawn4.global_position 
				add_child(bat1)
				add_child(bat2)
				add_child(bat3)
				add_child(bat4)
				mob_spawn_rounds -= 1
				await get_tree().create_timer(mob_wait_time).timeout
	elif  type == "frogs":
		var frog_spawn1 = $FrogSpawnPoint1
		var frog_spawn2 = $FrogSpawnPoint2
		if mob_spawn_rounds >= 1:
			for i in mob_spawn_rounds:
				var frog1 = frog_scene.instantiate()
				frog1.global_position = frog_spawn1.global_position
				var frog2 = frog_scene.instantiate()
				frog2.global_position = frog_spawn2.global_position
				add_child(frog1)
				add_child(frog2)
				mob_spawn_rounds -= 1
				await get_tree().create_timer(mob_wait_time).timeout
	wave_spawn_ended = true
	
		


func _process(delta): 
	if !Global.playerAlive:
		Global.gameStarted = false
		SceneTransitionAnimation.play("fade_in")
		get_tree(). change_scene_to_file("res://Scene/lobby_level.tscn")
		
		current_nodes = get_child_count()
		
	if wave_spawn_ended:
		print("TEST")
		position_to_next_wave()
2

To do this you should connect a signal from each enemy you spawn in the wave to a method. The signal should be emitted when the enemy dies and then the method checks if the amount of enemies that died is the same amount as the amount that you spawned that wave.

If yes then you can start the next wave

3

You’re assuming here that once everything has been removed, your tree will be back down to the number of nodes it had at the beginning. There are lots of ways this could potentially go wrong.

What I’d suggest is, create a mobs node. It can be empty, just a Node2D or whatever, but then you can do something like this:

var mobs: Node2D

var ready():
    [...]
    mobs = Node2D.new()
    add_child(mobs)
    [...]

func position_to_next_wave():
    if !mobs.get_child_count():
        # set up spawn timer
    [...]

func spawn(...)
    [...]
    for m in mob_spawn_rounds:
        [...]
        mobs.add_child(mob)

That isolates all your mobs in a branch of the scene tree where you can track, count and manipulate them without having to worry about other kinds of node gumming up your logic.

1 Like