Crashing, but why? I don't understand the error message

matheusmdx · May 27, 2024, 3:36pm

I recommend you open an issue on Godot github because no matter you do, Godot philosophy is never crash, so will be interesting send this for developers check

demolke · May 27, 2024, 9:21pm

+1 on opening an issue

The 2^32-1 now makes more sense - it’s BVHCommon::Invalid, so if you had BVH_ASSERTs enabled, it would crash there, instead of the next line.

github.com

godotengine/godot/blob/be56cab58c056c074d1e02cd0b38641204e39f41/core/math/bvh_public.inc#L122


      
          
          #ifdef BVH_EXPAND_LEAF_AABBS
          	if (USE_PAIRS) {
          		// scale the pairing expansion by the number of pairs.
          		abb.expand(_pairs[ref_id].scale_expansion_margin(_pairing_expansion));
          	} else {
          		abb.expand(_pairing_expansion);
          	}
          #endif
          
          	BVH_ASSERT(ref.tnode_id != BVHCommon::INVALID);
          	TNode &tnode = _nodes[ref.tnode_id];
          
          	// does it fit within the current leaf aabb?
          	if (tnode.aabb.is_other_within(abb)) {
          		// do nothing .. fast path .. not moved enough to need refit
          
          		// however we WILL update the exact aabb in the leaf, as this will be needed
          		// for accurate collision detection
          		TLeaf &leaf = _node_get_leaf(tnode);

Looks also like a race condition, but you’re right it’s very different from mine.

barrybaz · May 28, 2024, 10:32am

@matheusmdx
I’ve had another go at creating a simple project to demonstrate the issue, so far I have been unable to get it to crash. I didn’t want to open an issue without a reproduceable project, but I’m opening one now.
On searching again for things related to broad phase discarding and collision_object_3d code, I think it’s probably related to me turning on physics/3d/run_on_seperate_thread (it was at the start of the project when I did that). A quick test with it off seems to stop the crashing, like using set_deferred (but without the side effects). However it is hard to reproduce the crashing on demand and I’d previously thought I’d fixed the issue and I hadn’t.

EDIT:
Game crashes, but unable to recreate in a simple project, potentially a threading issue. · Issue #92467 · godotengine/godot (github.com)