How to code smooth jump instead of teleporting in the air

[system]

	Attention	Topic was automatically imported from the old Question2Answer platform.
	Asked By	fish

my code:

func _physics_process(delta):
var motion = Vector2()
motion = move_and_slide(motion, Vector2.UP)
velocity.y += gravity * delta
if Input.is_action_pressed(“ui_right”):
motion.x = 400
elif Input.is_action_pressed(“ui_left”):
motion.x = -400
elif Input.is_action_pressed(“jump”) and is_on_floor():
motion.y = -8000
else:
motion.x = 0
motion.y = 0
gravity = 400
move_and_slide(motion)

cos my jump teleports me to the air then slowly falls down

[system]

	Reply From:	chugwig

Your answer is right there in front of you, your jump is jerky but your fall isn’t. What’s the difference between the way you implement those two features?

TLDT: Your falling is implemented with an acceleration but your jumping is implemented by instantly setting the velocity. So come up with some jump_acceleration and a max_jump_speed (probably -8000 based on your code) and implement a process very similar to what you’re doing with gravity except capping the max speed (which you probably want in the opposite direction for gravity as well, depending on how far the character can fall and how high your gravity is)

[system]

	Reply From:	Magso

Bring motion.y back to the gravity amount gradually from a lower value.

elif Input.is_action_pressed("jump") and is_on_floor():
    motion.y = -800 #lower value
    var lerp_amount = 0.0
    while lerp_amount < 1:
        lerp_amount += delta
        motion.y = lerp(-800, gravity, lerp_amount)
        yield(get_tree(), "idle_frame")

Thank you!

I’d like to add that after I used this code in mine, my character seemed to have a unintended delay/cooldown on his jump.

I think is_on_floor() wasn’t being updated on time because the while loop was slowing the code by waiting the condition to end.

And my character reached the ground before the loop was done.

Writing this on the next line afteryield() fixed it.

if is_on_floor():
	break

Resulting in

while lerp_amount < 1:
    lerp_amount += delta
    motion.y = lerp(-800, gravity, lerp_amount)
    yield(get_tree(), "idle_frame")

    if is_on_floor():
        break

Random_Furry | 2022-11-05 17:09

[GNAWLI]

For godot 3 users, it really depends on where you place your input velocity and jump/falling logic

1. You need an impulse_velocity variable that saves the velocity of y
2. That impulse_velocity variable needs to be placed after you calculate the direction
3. Your jump falling logic needs to be between move_and_slide() and velocity variable

var velocity:Vector3
var direction:Vector3
var impulse_velocity:Vector3

func move(delta):
	var inputDirection = Input.get_vector(“move_left”,“move_right”,“move_forward”,“move_backward”)
	direction = Vector3(inputDirection.x, 0, inputDirection.y).normalized().rotated(Vector3.UP, camera.rotation.y)
	
	#1. save velocity variable, impulse_velocity:Vector3 also works, it just needs a impulse_velocity.y component
	impulse_velocity.y:float = velocity.y
	
	
	###can calculate anything else inbetween


	#2. calculate jump logic before move_and_slide()
	jump(delta)
	velocity = playerController.move_and_slide(velocity, Vector3.UP)


func jump(delta:float)->void:

	if playerController.is_on_floor():
		if(Input.is_action_pressed(“jump”)):
			velocity.y = impulse_velocity.y +jumpForce
	else:
			velocity.y =impulse_velocity.y -gravity*delta