'previously freed instance' error

:information_source: Attention Topic was automatically imported from the old Question2Answer platform.
:bust_in_silhouette: Asked By Zylann
:warning: Old Version Published before Godot 3 was released.

I’m getting this error:
Attempt to call function 'set_translation' in base 'previously freed instance' on a null instance.
In the _process(delta) function of a script inheriting MeshInstance, then the game breaks.

This error just popped out of nowhere in my project, and I don’t have a clue how :frowning:
There are no other errors in the console, and my code doesn’t contains any queue_free() or free()…
Any idea how to fix it?

:bust_in_silhouette: Reply From: kubecz3k

You need to check which object is getting freed, and instead of storing reference to this object you should store weakref to it. Thanks to weakref you will be able to check if object is still alive: Detect if an object reference is Freed? - Archive - Godot Forum

"While you know the object is stll alive:

var wr = weakref(object);

Then you can check like this:

if (!wr.get_ref()):
     #object is erased
    #object is fine so you can do something with it:


I can’t do this because the object on which I call set_translation is implicitly self:

func _process(delta):
	_anim_time += delta
	var k = _anim_time
	if k < 1.0:
		var pos = _normal_pos
		pos.y -= (1-k)*(1-k) * 64.0
		set_translation(_normal_pos) # here

My script basically sets the translation of selfin process, then suddenly it becomes freed…

I should have mentionned that my game uses threading. It’s not directly related to my script, but if I remove the thread I can’t reproduce the error (but the game gets laggy).
Basically the thread performs calculations, notifies the main thread with call_deferred("thread_finished"), and then in thread_finishedI wait for the thread to finish and spawn the MeshInstance on which my script is.

Zylann | 2016-05-02 14:03

Can a weakref() be invalidated between the time it is checked and the time it is used in the method? Safer would be

var ref = wr.get_ref()
if ref:
    #object is fine so you can do something with it:
     #object is erased

paul.holt | 2019-04-28 14:00

For people coming from Google trying to debug weird threading issues check out: Instancing nodes in thread causes random errors · Issue #30700 · godotengine/godot · GitHub

ichster | 2019-08-31 00:32

:bust_in_silhouette: Reply From: NOAHGengo

This is the easy way since being implemented. in May 2018
Here is an example of how I used this function in one of my scripts


LOL at the commit info
Add is_instance_valid() method to GDScript, ending more than a decade… …of pain
Add is_instance_valid() method to GDScript, ending more than a decade… · godotengine/godot@ff1e7cf · GitHub

bigbroken | 2022-01-20 21:08