Resources seems to be broken after updating to 4.5

Xanatos · September 19, 2025, 12:17pm

Godot Version

4.5

Question

I just did try to update my project to Godot 4.5. After the update it seems like the Resources did change.

I do use a custom resource to hold a set of playing cards, each playing card is a resource as well. Those cards are put together in a deck. That deck is loaded and should be placed on the playing field. With the update to Godot 4.5 the whole deck is empty if I print the content.

I did try to open up the resources, save them and hoped for some changes in the files fixing the issues, but seems like I’m out of luck. I tried to find something on the migration guide, but there’s nothing.

The working 4.4.1 build can be found here GitHub - D-Generation-S/Samory: A Memory like game, written in Godot. Does allow custom card decks to be side loaded.

Any idea what could cause that?

Xanatos · September 19, 2025, 12:30pm

Loading of the resources is done here:

github.com/D-Generation-S/Samory

src/game/CardSpawner.gd

main

class_name CardSpawner extends Node


signal field_constructed(cards_on_x: int, cards_on_y: int)
signal card_loading_done()
signal announce_field_size(area: Rect2)
signal card_placed(card: CardTemplate)

@export var card_template: PackedScene
@export var separation: int = 25
@onready var _card_target_ode: Node2D = self.get_parent() as Node2D

var load_thread: Thread = null

func _ready():
	process_mode = Node.PROCESS_MODE_DISABLED

func place_cards_from_deck(deck_to_user: MemoryDeckResource):
	load_thread = Thread.new()
	load_thread.start(build_card_layout.bind(deck_to_user, card_template, separation))

This file has been truncated. show original

While those are the resources in question can be found here:

named: MemoryCardResource and MemoryDeckResource

Hopefully that information might be helpful.

hexgrid · September 19, 2025, 3:40pm

You might want to scatter some telemetry through that. The questions that come to mind:

does the thread actually finish, or is it stuck somewhere?
is this a locking problem? I don’t see any locking…

Xanatos · September 19, 2025, 3:55pm

As soon as the code is accessing the deck ressource the return for cards is empty.

As the data aet loaded in that case is something I configured from within Godot the information should be there.

As the whole method is building the deck with an empty card set, nothing is getting placed. The whole code worked with 4.4.1 and stopped working with 4.5 which tells me something within threads or resource handling changed.

Might this be the result of the resource copy which was changed? Is a duplicate preventing resources stored inside an array to be copied as well?

Do resources get copied if used in a thread? Need to check my code if I did that somewhere by accident.

Xanatos · September 19, 2025, 4:18pm

@hexgrid Thanks man!

You did point me into the right direction. Somehow I did not think about that. I did copy the decks somewhere to translate them correctly, this was still set to “duplicate” after changing it to “duplicate_deep” the array was copied as well as expected.

All the cards are getting loaded once again. Seems like I updated successfully to 4.5.

system · October 19, 2025, 4:19pm

This topic was automatically closed 30 days after the last reply. New replies are no longer allowed.