Cannon doesn't point at me

Godot Version

Godot version 4.6.2

Question

I’m following octodemy’s making projectiles hit moving targets and I’m having trouble with the cannon’s aiming the barrel of the model keeps sticking upwards and on top of that the “aim_high” if statement was just glossed over, I’m not sure if it’s because the player character is the cannon target or if I missed something .

If you share code, please wrap it inside three backticks or replace the code in the next block:

extends Node3D
class_name  CannonWeapon

@export var EXPLOSION_IMPULSE: float = 25.0
@export var show_aim := true
@export var ammo_resource:PackedScene

@onready var spawn_point: Node3D = $Stand/Cannon/SpawnPoint
@onready var cannon: Node3D = $Stand/Cannon

var target_rotation_cannon_x: float = 0 # controls cannon vertical rotation
var target_rotation_y: float = 0 # rotate base horizontal rotation 
@export var target: Node3D = null 


func _physics_process(_delta: float) -> void:
	if show_aim:
		draw_aim()
	
	global_rotation.y = rotate_toward(global_rotation.y, target_rotation_y, _delta)
	cannon.global_rotation.x = rotate_toward(cannon.global_rotation.x, target_rotation_cannon_x, _delta)
	
	if target and is_instance_valid(target):
		aim_at_target()

func get_forward_direction() -> Vector3:
	return cannon.global_transform.basis.y  <<<<< originaly "-cannon.global_transform.basis.z" but shot the beam wrong

func do_attack()-> void:
	var cannonball = ammo_resource.instantiate() as RigidBody3D
	get_tree().current_scene.add_child(cannonball)
	cannonball.global_position = spawn_point.global_position
	
	var dir: Vector3 = get_forward_direction()
	cannonball.linear_velocity = dir*EXPLOSION_IMPULSE

func aim_at_target():
	if EXPLOSION_IMPULSE <= 0: return
	
	var plane_target :=  target.global_position
	plane_target.y = spawn_point.global_position.y
	
	# get xz plane direction to player (without y variation)
	var dir := spawn_point.global_position.direction_to(plane_target)
	# get the angle between cannon front and the direction
	target_rotation_y = dir.signed_angle_to(Vector3.FORWARD, Vector3.DOWN)
	
	get_angle_to_target(plane_target, target.global_position)

func get_angle_to_target(plane_target:Vector3, target_pos: Vector3):
	var v = EXPLOSION_IMPULSE
	
	var g: float = ProjectSettings.get_setting("physics/3d/default_gravity", 9.8)
	var x := spawn_point.global_position.distance_to(plane_target)
	var y := target_pos.y - spawn_point.global_position.y
	
	# var sq: float = (v*v*v*v - g*( (g*x*x) + (2.0*y*v*v) ) )
	var v2 = v*v
	var v4 = v2*v2
	var x2 = x*x
	var sq: float = (v4 - g*( (g*x2) + (2.0*y*v2) ) )
	if sq <= 0:
		#NaN
		return
	
	if aim_high:      <<<<<<< didn't say how/where to declare it
		sq = sqrt(sq)
	else:
		sq = -sqrt(sq)
	
	var angle = atan2(
		(v2 + sq), (g*x)
	)
	
	target_rotation_cannon_x = angle
func draw_aim()-> void:
	var vel: Vector3 = get_forward_direction()
	vel *= EXPLOSION_IMPULSE
	
	var tstep := 0.1 
	var start_pos := spawn_point.global_position
	var g: float = -ProjectSettings.get_setting("physics/3d/default_gravity", 9.8)
	
	var line_start := start_pos
	var line_end := start_pos
	var colors = [Color.BLACK, Color.RED]
	for i in range(1, 51):
		var dt := (i * tstep)
		line_end.x = dt * vel.x
		line_end.z = dt * vel.z
		line_end.y = dt * vel.y + (g*dt*dt)/2.0
		
		line_end += start_pos
		DebugDraw.draw_line(line_start, line_end, colors[i%2])
		line_start = line_end

func _input(event):
	if event.is_action_pressed("click"):
		do_attack()