Sprite movement calculated wrong?

Help Programming
, , , ,
1

Godot Version

4.6

Question

im not exactly sure whats happening, im thinking that the code is calculating my sprite’s direction incorrectly or something like that
progress_20260310_115523

it starts off normal however when trying to walk around, the LEFT and RIGHT facing sides get all messed up and end up almost de-syncing?
(id like to clarify that i dont actually understand half of my code, its from an online tutorial by Michael Games with a minor modification in place, so if you guys could please explain any suggestions like you would to a complete idiot :sweat_smile: )

heres my player code, specifically everything to do with movement inputs

func _process(delta: float) -> void:
	
	##direction.x = Input.get_action_strength("right") - Input.get_action_strength("left")
	##direction.y = Input.get_action_strength("down") - Input.get_action_strength("up")
	direction = Vector2(
		Input.get_axis("left", "right"),
		Input.get_axis("up", "down"),
	).normalized()
	pass


func _physics_process( delta ):
	move_and_slide()

func SetDirection() -> bool:
	
	var new_dir : Vector2 = cardinal_direction
	if direction == Vector2.ZERO:
		return false
	
	if direction.y == 0:
		new_dir = Vector2.LEFT if direction.x < 0 else Vector2.RIGHT
	elif direction.x == 0:
		new_dir = Vector2.UP if direction.y < 0 else Vector2.DOWN
	
	if new_dir == cardinal_direction:
		return false
	
	cardinal_direction = new_dir
	sprite.scale.x = sprite.scale.x * -1 if cardinal_direction == Vector2.LEFT else sprite.scale.x * 1
	return true

im happy to provide any other details if they help figuring this out

2

This looks like it’s overcomplicated to what it’s supposed to do. Here’s a slightly simpler script that utilizes the flip_h parameter of the Sprite2D, which you should be using.

extends CharacterBody2D


const SPEED: float = 100.0


@onready var sprite: Sprite2D = $Sprite2D


func _physics_process(_delta: float) -> void:
	velocity = Input.get_vector("ui_left", "ui_right", "ui_up", "ui_down")
	velocity *= SPEED
	
	if not is_zero_approx(velocity.x):
		sprite.flip_h = velocity.x < 0.0
	
	move_and_slide()

Here it is in action:

2 Likes
3

I explained in the other thread why multiplying the x scale by -1 would create precisely this issue. Also many people have already suggested to use sprite.flip_h.
Read the responses of the other thread carefully, try to understand the words said and not just copy paste something into your code. You managed to copy paste the one suggestion that was wrong.

1 Like
4

yeaaaaaa I figured that may be the case
not gonna lie I couldn’t figure out the horizontal flip as it kept giving out errors (might bee too dense to figure it out or blind to the proper solution) , so I tried the other suggestion left in the comment and it seemed to work well enough, turns out it really didn’t :sweat_smile:

5

Quick question about this, would it work just the same with a sprite that has an up and down facing animation? your suggestion appears really concise and I’m greatful for it, but from what I can understand in the code it only does a horizontal flip for left and right movement?

i want to try get my understanding of this well before I try implementing more code I don’t understand into the project if you don’t mind

6

For vertical movement you can’t just flip a sprite upside down like you would with the horizontal movement, so no - you can’t apply the same principle.

In your video I can see you already have an up and down movement animations - so you can just play them accordingly based on the player’s velocity.y component - the up animation if it’s negative and down animation if it’s positive. Try to implement it yourself and see if you can manage to do it. If not - post your problem here again.

If that’s relevant in your project, you should also consider a case of diagonal movement - then one of the animations (vertical or horizontal) should have a priority over the other.

1 Like