TPS game cant hurt enemy

[lacisajt1]

Godot Version

Godot 4.3

Question

Can i have some help please. My problem is : in my game i cant hurt enemies with shooting because the game crash and show me the error :" Invalid operands ‘int’ and ‘Array’ in operator ‘+’. " interesting when enemies shoot each other the program actually work and do damage and die , and of course they can kill me too, but when i shooting them the game crash.
Here is my code :
extends Node3D

const BLOOD_HIT_EFFECT = preload(“res://effects/blood/blood_hit_effect.tscn”)
const BLOOD_DECAL = preload(“res://effects/blood/blood_decal.tscn”)
const GIB = preload(“res://effects/gib/gib.tscn”)
@onready var blood_ray_cast: RayCast3D = $BloodRayCast

@export var max_health = 100
@onready var cur_health = max_health
@export var gib_when_damage_taken = 20
var has_gibbed = false

@export var blood_splatter_count = 3
@export var blood_splatter_range = 2.0
@export var blood_splatter_size_variance = 0.5
@export var gib_spawn_amnt = 5

@export var verbose = true

signal died
signal healed
signal damaged
signal gibbed
signal health_changed(cur_health, max_health)

func _ready():
health_changed.emit(cur_health, max_health)
if verbose:
print(“starting health: %s/%s” % [cur_health, max_health])

var damage_taken_this_frame = 0
var last_frame_damaged = -1

func hurt(damage_data: DamageData):
spawn_blood_effects(damage_data)

var cur_frame = Engine.get_process_frames()
if last_frame_damaged != cur_frame:
	damage_taken_this_frame = 0
last_frame_damaged = cur_frame
damage_taken_this_frame += damage_data.amount

var dead = cur_health <= 0
if dead and damage_taken_this_frame >= gib_when_damage_taken:
	gib()
	
if dead:
	return 

cur_health -= damage_data.amount
dead = cur_health <= 0
if dead:
	died.emit()
	if dead and damage_taken_this_frame >= gib_when_damage_taken:
		gib()
else:
	damaged.emit()
health_changed.emit(cur_health, max_health)
if verbose:
	print("damaged for %s, health: %s/%s" % [damage_data.amount,cur_health, max_health])

func gib():
if has_gibbed:
return
has_gibbed = true
gibbed.emit()
for _i in (gib_spawn_amnt):
var gib_inst = GIB.instantiate()
get_tree().get_root().add_child(gib_inst)
gib_inst.global_position = global_position
gib_inst.add_to_group(“instanced”)

func heal(amount : int):
if cur_health <= 0:
return
cur_health = clamp(cur_health + amount, 0 , max_health)
healed.emit()
health_changed.emit(cur_health, max_health)
if verbose:
print(“healed for %s, health: %s/%s” % [amount,cur_health, max_health])

func spawn_blood_effects(damage_data: DamageData):
var blood_hit_effect = BLOOD_HIT_EFFECT.instantiate()
get_tree().get_root().add_child(blood_hit_effect)
blood_hit_effect.global_position = damage_data.hit_pos

blood_ray_cast.enabled = true
for _i in blood_splatter_count:
	var h_angle = randf_range(0.0, PI / 2.0)
	var v_angle = randf_range(0.0, TAU)
	var dir = Vector3.DOWN.rotated(Vector3.RIGHT, h_angle)
	dir = dir.rotated(Vector3.UP, v_angle)
	var raycast_to = global_position + dir * blood_splatter_range
	blood_ray_cast.target_position = blood_ray_cast.to_local(raycast_to)
	blood_ray_cast.force_raycast_update()
	if !blood_ray_cast.is_colliding():
		continue
	
	var hit_pos = blood_ray_cast.get_collision_point()
	var hit_normal = blood_ray_cast.get_collision_normal()
	var blood_decal = BLOOD_DECAL.instantiate()
	get_tree().get_root().add_child(blood_decal)
	blood_decal.global_position = hit_pos
	blood_decal.add_to_group("instanced")
	var look_at_pos = hit_pos + hit_normal
	if hit_normal.is_equal_approx(Vector3.UP) or hit_normal.is_equal_approx(Vector3.DOWN):
		blood_decal.look_at(look_at_pos, Vector3.RIGHT)
	else:
		blood_decal.look_at(look_at_pos)
	
	blood_decal.rotate_object_local(Vector3.FORWARD, randf_range(0.0, TAU))
	blood_decal.scale *= 1.0 + randf_range(-blood_splatter_size_variance, blood_splatter_size_variance)
	
blood_ray_cast.enabled = false
	
the error calling this line : 

“damage_taken_this_frame += damage_data.amount”

i try to convert the damage to int but then something other happen and call error to another script :
Invalid assignment of property or key ‘amount’ with value of type ‘Array’ on a base object of type ‘Node (DamageData)’.

Can someone help me , im not good at programing

[redflare]

I think you have an issue with the damage_data parameter… try to play around with the following …

extends Node3D

const BLOOD_HIT_EFFECT = preload("res://effects/blood/blood_hit_effect.tscn")
const BLOOD_DECAL = preload("res://effects/blood/blood_decal.tscn")
const GIB = preload("res://effects/gib/gib.tscn")
@onready var blood_ray_cast: RayCast3D = $BloodRayCast

@export var max_health = 100
@onready var cur_health = max_health
@export var gib_when_damage_taken = 20
var has_gibbed = false

@export var blood_splatter_count = 3
@export var blood_splatter_range = 2.0
@export var blood_splatter_size_variance = 0.5
@export var gib_spawn_amnt = 5

@export var verbose = true

signal died
signal healed
signal damaged
signal gibbed
signal health_changed(cur_health, max_health)

func _ready():
    health_changed.emit(cur_health, max_health)
    if verbose:
        print("starting health: %s/%s" % [cur_health, max_health])

var damage_taken_this_frame = 0
var last_frame_damaged = -1

func hurt(damage_data: DamageData):
    # First, ensure damage_data.amount is an integer
    var damage_amount = 0
    if damage_data and damage_data.amount != null:
        if damage_data.amount is Array:
            # If it's an array, take the first element or use 0
            damage_amount = int(damage_data.amount[0]) if damage_data.amount.size() > 0 else 0
        else:
            # Otherwise, convert to int
            damage_amount = int(damage_data.amount)
    
    spawn_blood_effects(damage_data)

    var cur_frame = Engine.get_process_frames()
    if last_frame_damaged != cur_frame:
        damage_taken_this_frame = 0
    last_frame_damaged = cur_frame
    
    # Use the converted damage_amount
    damage_taken_this_frame += damage_amount

    var dead = cur_health <= 0
    if dead and damage_taken_this_frame >= gib_when_damage_taken:
        gib()
        
    if dead:
        return 

    # Use the converted damage_amount
    cur_health -= damage_amount
    dead = cur_health <= 0
    if dead:
        died.emit()
        if dead and damage_taken_this_frame >= gib_when_damage_taken:
            gib()
    else:
        damaged.emit()
    health_changed.emit(cur_health, max_health)
    if verbose:
        print("damaged for %s, health: %s/%s" % [damage_amount, cur_health, max_health])

func gib():
    if has_gibbed:
        return
    has_gibbed = true
    gibbed.emit()
    for _i in (gib_spawn_amnt):
        var gib_inst = GIB.instantiate()
        get_tree().get_root().add_child(gib_inst)
        gib_inst.global_position = global_position
        gib_inst.add_to_group("instanced")

func heal(amount : int):
    if cur_health <= 0:
        return
    cur_health = clamp(cur_health + amount, 0 , max_health)
    healed.emit()
    health_changed.emit(cur_health, max_health)
    if verbose:
        print("healed for %s, health: %s/%s" % [amount,cur_health, max_health])

func spawn_blood_effects(damage_data: DamageData):
    var blood_hit_effect = BLOOD_HIT_EFFECT.instantiate()
    get_tree().get_root().add_child(blood_hit_effect)
    blood_hit_effect.global_position = damage_data.hit_pos

    blood_ray_cast.enabled = true
    for _i in blood_splatter_count:
        var h_angle = randf_range(0.0, PI / 2.0)
        var v_angle = randf_range(0.0, TAU)
        var dir = Vector3.DOWN.rotated(Vector3.RIGHT, h_angle)
        dir = dir.rotated(Vector3.UP, v_angle)
        var raycast_to = global_position + dir * blood_splatter_range
        blood_ray_cast.target_position = blood_ray_cast.to_local(raycast_to)
        blood_ray_cast.force_raycast_update()
        if !blood_ray_cast.is_colliding():
            continue
        
        var hit_pos = blood_ray_cast.get_collision_point()
        var hit_normal = blood_ray_cast.get_collision_normal()
        var blood_decal = BLOOD_DECAL.instantiate()
        get_tree().get_root().add_child(blood_decal)
        blood_decal.global_position = hit_pos
        blood_decal.add_to_group("instanced")
        var look_at_pos = hit_pos + hit_normal
        if hit_normal.is_equal_approx(Vector3.UP) or hit_normal.is_equal_approx(Vector3.DOWN):
            blood_decal.look_at(look_at_pos, Vector3.RIGHT)
        else:
            blood_decal.look_at(look_at_pos)
        
        blood_decal.rotate_object_local(Vector3.FORWARD, randf_range(0.0, TAU))
        blood_decal.scale *= 1.0 + randf_range(-blood_splatter_size_variance, blood_splatter_size_variance)
        
    blood_ray_cast.enabled = false

[lacisajt1]

Thank you very much for the quick answer, i used your code change 2 lines and perfectly worked ! Thank you once again you helped me a lot !